Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a user callback for pre process record #20584

Merged
merged 7 commits into from
May 13, 2023
Merged

Add a user callback for pre process record #20584

merged 7 commits into from
May 13, 2023

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Apr 27, 2023 •
edited
Loading

Description

  • Add pre_process_record_kb and pre_process_record_user to pre_process_record_quantum
  • Move prototype declarations into quantum.h
  • Update unit test with an additional key

These changes are no-op by default.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Apr 27, 2023
drashna
drashna reviewed Apr 27, 2023
View reviewed changes
quantum/action.c Outdated Show resolved Hide resolved
@filterpaper filterpaper requested a review from drashna April 27, 2023 04:25
drashna
drashna reviewed Apr 27, 2023
View reviewed changes
quantum/quantum.c Outdated Show resolved Hide resolved
gnusenpai
gnusenpai reviewed Apr 27, 2023
View reviewed changes
quantum/quantum.h Outdated Show resolved Hide resolved
@filterpaper filterpaper changed the title Add a user callback for pre process record quantum Add a user callback for pre process record Apr 28, 2023
@filterpaper filterpaper requested a review from drashna April 28, 2023 00:44
@filterpaper filterpaper force-pushed the pre-quantum-user branch 5 times, most recently from 7646e01 to a1926ed Compare April 29, 2023 02:41
@filterpaper filterpaper marked this pull request as draft April 29, 2023 02:51
@filterpaper
Copy link
Contributor Author

filterpaper commented Apr 29, 2023 •
edited
Loading

Unit test trace output matches TEST_F(ActionLayer, LayerTapReleasedBeforeKeypressReleaseWithModifiers):

ActionLayer.LayerTapReleasedBeforeKeypressReleaseWithModifiers failed!
[ LEVEL    ] [TIME] [EVENT]
[ INFO     ] 0      tapping term is 200ms
[ TRACE    ] 0      pressed:  LT(1, KC_T)
[ TRACE    ] 0      200 keyboard task loops
[ TRACE    ] 200    pressed:  QK_MODS(KC_9, QK_RALT)
[ TRACE    ] 200    1 keyboard task loop
[ TRACE    ] 200    report:   () [KC_RIGHT_ALT]
[ TRACE    ] 200    report:   (KC_9) [KC_RIGHT_ALT]
[ TRACE    ] 201    released: LT(1, KC_T) was pressed for 201ms
[ TRACE    ] 201    1 keyboard task loop
[ TRACE    ] 202    released: QK_MODS(KC_9, QK_RALT) was pressed for 2ms
[ TRACE    ] 202    1 keyboard task loop
[ TRACE    ] 202    report:   () [KC_RIGHT_ALT]
[ TRACE    ] 202    report:   empty
[ INFO     ] 203    test fixture clean-up start.
[ TRACE    ] 203    2000 keyboard task loops
[ TRACE    ] 2203   2000 keyboard task loops
[ INFO     ] 4203   test fixture clean-up end.

Can't tell what's is the trigger of the following error when return pre_process_record_kb(keycode, record); is introduced:

tests/test_common/test_fixture.cpp:167: Failure
Failed
no key is mapped for layer 0 and (column,row) 1,0)
[  FAILED  ] ActionLayer.LayerTapReleasedBeforeKeypressReleaseWithModifiers (0 ms)

@filterpaper filterpaper marked this pull request as ready for review April 29, 2023 04:07
@sigprof
Copy link
Contributor

sigprof commented Apr 29, 2023

The keymap for that test probably needs to have an extra mapping added for layer 0 — something like KeymapKey{0, 1, 0, KC_A}. Apparently the test simulates the second key press exactly at the tapping term, therefore at the time the second key gets looked up inside pre_process_record_quantum() layer 1 is not active yet; and TestFixture::get_keycode() treats any attempt to access undefined keymap positions as an error instead of assuming something like KC_NO.

@filterpaper
Copy link
Contributor Author

The keymap for that test probably needs to have an extra mapping added for layer 0 — something like KeymapKey{0, 1, 0, KC_A}. Apparently the test simulates the second key press exactly at the tapping term, therefore at the time the second key gets looked up inside pre_process_record_quantum() layer 1 is not active yet; and TestFixture::get_keycode() treats any attempt to access undefined keymap positions as an error instead of assuming something like KC_NO.

Thanks for the guidance.

@drashna drashna requested a review from a team May 2, 2023 03:23
@waffle87 waffle87 merged commit 128f808 into qmk:develop May 13, 2023
@filterpaper filterpaper deleted the pre-quantum-user branch May 13, 2023 07:44
@filterpaper filterpaper mentioned this pull request May 14, 2023
Closed
14 tasks
freznel10 added a commit to freznel10/qmk_firmware that referenced this pull request May 14, 2023
@freznel10
Squashed commit of the following:
54cc54b 
commit 13a989d
Author: jack <0x6A73@pm.me>
Date:   Sun May 14 08:17:08 2023 +0100

    Fixup latinpadble (qmk#20924)

commit d52e7d4
Merge: f8f2fd0 09666ea
Author: QMK Bot <hello@qmk.fm>
Date:   Sun May 14 07:16:04 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 09666ea
Author: jotix <69703151+jotix@users.noreply.github.com>
Date:   Sun May 14 04:15:27 2023 -0300

    jotix keymap update (qmk#20902)

commit f8f2fd0
Merge: df37606 0b672f8
Author: QMK Bot <hello@qmk.fm>
Date:   Sun May 14 05:33:11 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 0b672f8
Author: Nick Brassel <nick@tzarc.org>
Date:   Sun May 14 15:32:34 2023 +1000

    Far better VSCode intellisense support using clangd. (qmk#20382)

commit df37606
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 20:08:03 2023 -0700

    MisterKnife Knife66 ISO Layout Additions II (qmk#20930)

    * rename LAYOUT_all to LAYOUT_split_space_split_bs

    * rename LAYOUT_625u_space to LAYOUT_625u_space_split_bs

    * add LAYOUT_split_space

    * add LAYOUT_625u_space

    * remove LAYOUT_625u_space -> LAYOUT_625u_space_split_bs alias

    Fixes a lint error.

commit 4dea80f
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 17:27:40 2023 -0700

    MisterKnife Knife66 Layout Additions (qmk#20929)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_split_space_split_bs

    * add LAYOUT_split_space

    * add LAYOUT_625u_space_split_bs

    * add LAYOUT_625u_space

    * info.json: update listed maintainer

commit 77d7c00
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 16:44:39 2023 -0700

    Mechlovin Studio Jay60 Community Layout Support (qmk#20928)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_ansi

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan

    * enable Community Layout support

commit 747079e
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 15:25:50 2023 -0700

    MC-76K: rename LAYOUT_all to LAYOUT (qmk#20927)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT

commit 2bf679a
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 15:25:38 2023 -0700

    FR4Boards unix60 Layout Additions (qmk#20926)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_60_hhkb

    * add LAYOUT_60_hhkb_iso

    * add reference keymaps

    * enable Community Layout support

commit e349ca2
Author: jack <0x6A73@pm.me>
Date:   Sat May 13 21:31:17 2023 +0100

    Fixup zwag75 (qmk#20923)

commit b09b2a8
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 06:32:16 2023 -0700

    4pplet Eagle Viper REP Rev B Community Layout Support (qmk#20921)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * info.json: correct layout data

    * rename LAYOUT to LAYOUT_all

    * add LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_ansi

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan

    * add LAYOUT_60_hhkb

    * add LAYOUT_60_iso_split_bs_rshift

    * add LAYOUT_60_iso

    * add LAYOUT_60_iso_tsangan_split_bs_rshift

    * add LAYOUT_60_iso_tsangan

    * enable Community Layout support

commit 843e1d6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 05:30:35 2023 -0700

    Wilba Tech WT80-BC Community Layout Support (qmk#20920)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan

    * add LAYOUT_tkl_ansi_wkl

    * enable Community Layout support

    * readme.md: update metadata section

    - convert to list
    - update maintainer username

commit e950b75
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 05:18:09 2023 -0700

    Xiudi XD004: rename LAYOUT_all to LAYOUT_ortho_1x4 (qmk#20919)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ortho_1x4

commit 327e8d5
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 05:06:34 2023 -0700

    Pearl Boards Atlas Layout Additions (qmk#20918)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * info.json: correct layout data

    Moves the position representing the Rotary Encoder to the top of the layout.

    * refactor keymaps

    Applies the following changes to the `default` and `via` keymaps:

    - four-space indent
    - use of QMK-native keycode aliases
    - numerically-indexed keymap layers
    - updated grid alignment of keycodes

    * add LAYOUT_ansi_blocker_tsangan_wkl_split_bs

    * add LAYOUT_ansi_blocker_tsangan_wkl

    * add LAYOUT_iso_blocker_tsangan_wkl_split_bs

    * add LAYOUT_iso_blocker_tsangan_wkl

commit 7705641
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 04:22:16 2023 -0700

    SawnsProjects Amber80 Solder Community Layout Support (qmk#20917)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_f13_ansi_tsangan

    * add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift

    * add LAYOUT_tkl_f13_iso_tsangan

    * enable Community Layout support

commit e809b04
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 03:47:21 2023 -0700

    ZTBoards Noon Layout Addition (qmk#20913)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi_blocker_wkl_split_bs

    * add LAYOUT_ansi_blocker_wkl

commit 7345f20
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 02:33:13 2023 -0700

    ZTBoards After Layout Addition (qmk#20912)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_wkl_split_bs

    * add LAYOUT_65_ansi_wkl

commit b05e954
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 02:11:55 2023 -0700

    Zicodia TKLFRLNRLMLAO Layout Addition (qmk#20908)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_iso with reference keymap

commit c4e91ca
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 01:51:07 2023 -0700

    Yugo-M Controller Layout Additions (qmk#20907)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_fullsize_ansi_wkl

    * add LAYOUT_fullsize_iso_wkl

commit d4ce2b3
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Sat May 13 01:16:10 2023 -0700

    YMDK YM68 Community Layout Support (qmk#20906)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_65_ansi_split_bs

    * add LAYOUT_65_ansi

    * add LAYOUT_65_iso_split_bs

    * add LAYOUT_65_iso

    * enable Community Layout support

commit 7cd879d
Merge: 38ba723 cead6af
Author: QMK Bot <hello@qmk.fm>
Date:   Sat May 13 08:02:14 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit cead6af
Author: takashicompany <t@kashi.company>
Date:   Sat May 13 17:01:31 2023 +0900

    Add new keyboard "Ergomirage" (qmk#20655)

    Co-authored-by: Drashna Jaelre <drashna@live.com>
    Co-authored-by: Ryan <fauxpark@gmail.com>

commit 38ba723
Merge: e264cd4 9992d5d
Author: QMK Bot <hello@qmk.fm>
Date:   Sat May 13 08:00:54 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 9992d5d
Author: DeskDaily <65656486+DeskDaily@users.noreply.github.com>
Date:   Sat May 13 16:00:14 2023 +0800

    [Keyboard] Add Zwag75 keyboard (qmk#20757)

    Co-authored-by: Neil Brian Ramirez <nightlykeyboards@gmail.com>
    Co-authored-by: Neil Brian Ramirez <nightlyboards@gmail.com>

commit e264cd4
Merge: 128f808 b1cd166
Author: QMK Bot <hello@qmk.fm>
Date:   Sat May 13 07:58:40 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit b1cd166
Author: biuboom-jun <65760331+biuboom-jun@users.noreply.github.com>
Date:   Sat May 13 15:57:58 2023 +0800

    [Keyboard] Add kibou/fukuro (qmk#20771)

    Co-authored-by: jack <0x6a73@protonmail.com>

commit 128f808
Author: Albert Y <76888457+filterpaper@users.noreply.github.com>
Date:   Sat May 13 15:42:06 2023 +0800

    Add a user callback for pre process record (qmk#20584)

commit 8cb13b6
Merge: 838205d dc9df5a
Author: QMK Bot <hello@qmk.fm>
Date:   Sat May 13 07:33:41 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit dc9df5a
Author: Moritz Plattner <moritz.plattner@gmx.net>
Date:   Sat May 13 09:32:39 2023 +0200

    [Keyboard] Add Teleport TKL (qmk#20469)

    Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>

commit 838205d
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 23:55:54 2023 -0700

    YMDK Wings Layout Addition (qmk#20900)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi_split_bs

    * add LAYOUT_ansi

    * info.json: update maintainer field

commit 609c590
Merge: eefb7c4 8726a26
Author: QMK Bot <hello@qmk.fm>
Date:   Sat May 13 06:20:04 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 8726a26
Author: peepeetee <43021794+peepeetee@users.noreply.github.com>
Date:   Sat May 13 01:19:18 2023 -0500

    momokai tap_* rgb modes and bootmagic key update (qmk#20126)

commit eefb7c4
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 22:36:05 2023 -0700

    YDKB Grape Layout Additions (qmk#20899)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_ansi_split_bs

    * add LAYOUT_ansi

    * add LAYOUT_ansi_wkl_split_bs

    * add LAYOUT_ansi_wkl

    * add LAYOUT_iso_split_bs

    * add LAYOUT_iso

    * add LAYOUT_iso_wkl_split_bs

    * add LAYOUT_iso_wkl

commit d205763
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 22:24:07 2023 -0700

    YDKB Chili Community Layout Support (qmk#20895)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_fullsize_ansi

    * add LAYOUT_fullsize_iso

    * enable Community Layout support

    * readme.md: fix image reference

commit 9d6ed65
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 22:02:08 2023 -0700

    Xelus Valor FRL TKL Layout Additions (qmk#20893)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi_split_bs_rshift

    * add LAYOUT_ansi

commit cede709
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 21:10:04 2023 -0700

    Xelus Trinity XT TKL Layout Additions (qmk#20892)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi_split_space_split_bs_rshift

    * add LAYOUT_ansi_split_space

    * add LAYOUT_ansi_wkl_split_bs_rshift

    * add LAYOUT_ansi_wkl

commit a897c44
Merge: f85001e b833cd0
Author: QMK Bot <hello@qmk.fm>
Date:   Sat May 13 03:44:36 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit b833cd0
Author: Daniel Shields <1530706+shieldsd@users.noreply.github.com>
Date:   Sat May 13 04:43:52 2023 +0100

    [Keymap] Add caps word enable to dshields keymaps (qmk#20862)

    Co-authored-by: Daniel Shields <dshields@cboe.com>

commit f85001e
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 20:15:37 2023 -0700

    Xelus Pachi rev1 Community Layout Support (qmk#20891)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_tkl_ansi_split_bs_rshift

    * add LAYOUT_tkl_ansi

    * add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_ansi_tsangan

    * add LAYOUT_tkl_iso_split_bs_rshift

    * add LAYOUT_tkl_iso

    * add LAYOUT_tkl_iso_tsangan_split_bs_rshift

    * add LAYOUT_tkl_iso_tsangan

    * add LAYOUT_tkl_f13_ansi_split_bs_rshift

    * add LAYOUT_tkl_f13_ansi

    * add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_f13_ansi_tsangan

    * add LAYOUT_tkl_f13_iso_split_bs_rshift

    * add LAYOUT_tkl_f13_iso

    * add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift

    * add LAYOUT_tkl_f13_iso_tsangan

    * enable Community Layout support

commit 73734a1
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 19:51:47 2023 -0700

    Xelus Pachi Mini 32U4 Community Layout Support (qmk#20889)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_tkl_f13_ansi_split_bs_rshift

    * add LAYOUT_tkl_f13_ansi

    * add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_f13_ansi_tsangan

    * add LAYOUT_tkl_ansi_split_bs_rshift

    * add LAYOUT_tkl_ansi

    * add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_ansi_tsangan

    * add LAYOUT_tkl_f13_iso_split_bs_rshift

    * add LAYOUT_tkl_f13_iso

    * add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift

    * add LAYOUT_tkl_f13_iso_tsangan

    * add LAYOUT_tkl_iso_split_bs_rshift

    * add LAYOUT_tkl_iso

    * add LAYOUT_tkl_iso_tsangan_split_bs_rshift

    * add LAYOUT_tkl_iso_tsangan

    * enable Community Layout support

commit ec145f2
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 19:28:04 2023 -0700

    Xelus La+ Layout Addition (qmk#20888)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_rwkl_split_bs

    * add LAYOUT_65_ansi_rwkl

commit 29c6fd2
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 19:02:41 2023 -0700

    Xelus Kangaroo Layout Additions (qmk#20887)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi_split_bs_rshift

    * add LAYOUT_ansi

    * add LAYOUT_ansi_tsangan_split_bs_rshift

    * add LAYOUT_ansi_tsangan

commit a5917ac
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 18:34:19 2023 -0700

    Xelus Dharma Layout Additions (qmk#20886)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi_rwkl_split_bs

    * add LAYOUT_ansi_rwkl

    * add LAYOUT_ansi_wkl_split_bs

    * add LAYOUT_ansi_wkl

commit a35af3f
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 18:15:29 2023 -0700

    Xelus AkiS Layout Additions (qmk#20885)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_65_ansi_wkl_split_bs

    * add LAYOUT_65_ansi_wkl

    * add LAYOUT_65_iso_wkl_split_bs

    * add LAYOUT_65_iso_wkl

commit 1e3b360
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 17:43:10 2023 -0700

    Winkeyless B87 Community Layout Support (qmk#20884)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_tkl_ansi_split_bs_rshift

    * add LAYOUT_tkl_ansi

    * add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_ansi_tsangan

    * add LAYOUT_tkl_ansi_wkl_split_bs_rshift

    * add LAYOUT_tkl_ansi_wkl

    * add LAYOUT_tkl_iso_split_bs_rshift

    * add LAYOUT_tkl_iso

    * add LAYOUT_tkl_iso_tsangan_split_bs_rshift

    * add LAYOUT_tkl_iso_tsangan

    * add LAYOUT_tkl_iso_wkl_split_bs_rshift

    * add LAYOUT_tkl_iso_wkl

    * enable Community Layout support

    * readme.md: update Hardware Availability link

commit d70d781
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 17:15:12 2023 -0700

    Scarlet Bandana Layout Additions (qmk#20882)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * info.json: correct layout data

    * rename LAYOUT_all to LAYOUT_65_xt_ansi_split_space_split_bs

    * add LAYOUT_65_xt_ansi_split_space

    * add LAYOUT_65_xt_ansi_split_bs

    * add LAYOUT_65_xt_ansi

    * update readme.md

    - convert metadata section to list
    - update Availability link (mark as "no longer available" as the vendor no longer ships)
    - add Flashing and Bootloader instructions

commit bc82bc4
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 16:35:23 2023 -0700

    Wilba Tech WT80-G Layout Additions and Touch-Up (qmk#20880)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_tkl_ansi_split_bs_rshift

    * add LAYOUT_tkl_ansi

    * add LAYOUT_tkl_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_ansi_tsangan

    * add LAYOUT_tkl_ansi_wkl_split_bs_rshift

    * add LAYOUT_tkl_ansi_wkl

    * add LAYOUT_tkl_iso_split_bs_rshift

    * add LAYOUT_tkl_iso

    * add LAYOUT_tkl_iso_tsangan_split_bs_rshift

    * add LAYOUT_tkl_iso_tsangan

    * add LAYOUT_tkl_iso_wkl_split_bs_rshift

    * add LAYOUT_tkl_iso_wkl

    * enable Community Layout support

    * readme.md: update maintainer username

commit 8874c61
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 16:12:24 2023 -0700

    Wilba Tech WT75-C Layout Additions and Touch-Up (qmk#20879)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi_rwkl_split_bs

    * add LAYOUT_ansi_rwkl

    * readme.md: update metadata section

    - convert to list
    - update maintainer username

commit 89bc264
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 15:30:20 2023 -0700

    Wilba Tech WT75-B Layout Additions and Touch-Up (qmk#20878)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_75_ansi_blocker_split_bs

    * add LAYOUT_75_ansi_blocker

    * add LAYOUT_75_ansi_blocker_tsangan_split_bs

    * add LAYOUT_75_ansi_blocker_tsangan

    * readme.md: update metadata section

    - convert to list
    - update maintainer username

commit 1d74192
Merge: a31eea6 6fdb997
Author: QMK Bot <hello@qmk.fm>
Date:   Fri May 12 21:43:39 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit 6fdb997
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri May 12 22:42:58 2023 +0100

    Bump anothrNick/github-tag-action from 1.63.0 to 1.64.0 (qmk#20911)

    Bumps [anothrNick/github-tag-action](https://github.com/anothrNick/github-tag-action) from 1.63.0 to 1.64.0.
    - [Release notes](https://github.com/anothrNick/github-tag-action/releases)
    - [Commits](anothrNick/github-tag-action@1.63.0...1.64.0)

    ---
    updated-dependencies:
    - dependency-name: anothrNick/github-tag-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a31eea6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 07:33:41 2023 -0700

    WinKeys Mini Winni: rename LAYOUT_all to LAYOUT_ortho_2x4 (qmk#20881)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ortho_2x4

    * info.json: update maintainer field

    Use the maintainer's GitHub username instead of their display name.

commit f8fb35d
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 07:33:16 2023 -0700

    YMDK Wings Hotswap: rename LAYOUT_all to LAYOUT (qmk#20901)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT

    * info.json: update listed maintainer

commit bd4c834
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 01:20:38 2023 -0700

    Wilba Tech WT75-A Layout Additions and Touch-Up (qmk#20877)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi_blocker_split_bs

    * add LAYOUT_ansi_blocker

    * add LAYOUT_ansi_blocker_tsangan_split_bs

    * add LAYOUT_ansi_blocker_tsangan

    * readme.md: update metadata section

    - convert to list
    - update maintainer username

commit 9149402
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 01:02:10 2023 -0700

    Wilba Tech WT65-XT: rename LAYOUT_all to LAYOUT_65_xt_ansi_blocker_tsangan  (qmk#20873)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_xt_ansi_blocker_tsangan

    * readme.md: update maintainer username

commit 38b908d
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 00:41:52 2023 -0700

    Wilba Tech WT70-JB Layout Addition and Touch-Up (qmk#20876)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_tkl_nofrow_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_nofrow_ansi_tsangan

    * readme.md: update maintainer username

commit c8b6137
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Fri May 12 00:24:44 2023 -0700

    Wilba Tech WT69-A Layout Addition and Touch-Up (qmk#20875)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_xt_ansi_blocker_tsangan_split_bs

    * add LAYOUT_65_xt_ansi_blocker_tsangan

    * readme.md: update metadata section

    - convert to list
    - update maintainer username

commit a121ba0
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 23:18:25 2023 -0700

    Wilba Tech WT65-XTX Layout Additions and Touch-Up (qmk#20874)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_xt_ansi_blocker_split_bs

    * add LAYOUT_65_xt_ansi_blocker

    * add LAYOUT_65_xt_ansi_blocker_tsangan_split_bs

    * add LAYOUT_65_xt_ansi_blocker_tsangan

    * readme.md: update maintainer username

commit 46c81e0
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 21:37:44 2023 -0700

    Wilba Tech WT65-G2 Layout Additions and Touch-Up (qmk#20872)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_65_ansi_blocker_wkl_split_bs

    * add LAYOUT_65_ansi_blocker_wkl

    * add LAYOUT_65_iso_blocker_wkl_split_bs

    * add LAYOUT_65_iso_blocker_wkl

    * readme.md: update maintainer username

commit 1ce77c6
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 18:29:46 2023 -0700

    Wilba Tech WT65-G Layout Additions and Touch-Up (qmk#20871)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_65_ansi_blocker_split_bs

    * add LAYOUT_65_ansi_blocker

    * add LAYOUT_65_ansi_blocker_tsangan_split_bs

    * add LAYOUT_65_ansi_blocker_tsangan

    * add LAYOUT_65_iso_blocker_split_bs

    * add LAYOUT_65_iso_blocker

    * add LAYOUT_65_iso_blocker_tsangan_split_bs

    * add LAYOUT_65_iso_blocker_tsangan

    * enable Community Layout support

    * readme.md: update maintainer username

commit a5720a9
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 18:15:54 2023 -0700

    Wilba Tech WT65-FX Community Layout Support (qmk#20870)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_blocker_split_bs

    * add LAYOUT_65_ansi_blocker

    * add LAYOUT_65_ansi_blocker_tsangan_split_bs

    * add LAYOUT_65_ansi_blocker_tsangan

    * enable Community Layout support

    * readme.md: update maintainer username

commit 7a98f57
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 17:45:38 2023 -0700

    Wilba Tech WT65-F Community Layout Support and Touch-Up (qmk#20869)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_blocker

    * enable Community Layout support

    * readme.md: update maintainer username

commit fdcf2ae
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 13:51:07 2023 -0700

    Wilba Tech WT65-B Layout Addition and Touch-Up (qmk#20867)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_blocker_wkl_split_bs

    * add LAYOUT_65_ansi_blocker_wkl

    * readme.md: update metadata section

commit 8165960
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 13:38:57 2023 -0700

    Wilba Tech WT65-A Community Layout Support and Touch-Up (qmk#20866)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_blocker_split_bs

    * add LAYOUT_65_ansi_blocker

    * add LAYOUT_65_ansi_blocker_tsangan_split_bs

    * add LAYOUT_65_ansi_blocker_tsangan

    * enable Community Layout support

    * readme.md: update maintainer username

commit 22aad0c
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 13:19:08 2023 -0700

    Wilba Tech WT60-XT Layout Additions and Touch-Up (qmk#20865)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_60_xt_ansi_split_bs_rshift

    * add LAYOUT_60_xt_ansi

    * add LAYOUT_60_xt_tsangan_hhkb

    * add LAYOUT_60_xt_ansi_tsangan

    * add LAYOUT_60_xt_ansi_wkl_split_bs_rshift

    * add LAYOUT_60_xt_ansi_wkl

    * add LAYOUT_60_xt_iso_split_bs_rshift

    * add LAYOUT_60_xt_iso

    * add LAYOUT_60_xt_iso_tsangan_split_bs_rshift

    * add LAYOUT_60_xt_iso_tsangan

    * add LAYOUT_60_xt_iso_wkl_split_bs_rshift

    * add LAYOUT_60_xt_iso_wkl

    * readme.md: update maintainer username

commit c890d40
Merge: ee5438a f8d01e5
Author: QMK Bot <hello@qmk.fm>
Date:   Thu May 11 20:05:17 2023 +0000

    Merge remote-tracking branch 'origin/master' into develop

commit f8d01e5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu May 11 21:04:34 2023 +0100

    Bump anothrNick/github-tag-action from 1.62.0 to 1.63.0 (qmk#20868)

    Bumps [anothrNick/github-tag-action](https://github.com/anothrNick/github-tag-action) from 1.62.0 to 1.63.0.
    - [Release notes](https://github.com/anothrNick/github-tag-action/releases)
    - [Commits](anothrNick/github-tag-action@1.62.0...1.63.0)

    ---
    updated-dependencies:
    - dependency-name: anothrNick/github-tag-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit ee5438a
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 12:47:30 2023 -0700

    Wilba Tech WT60-H2: rename LAYOUT_all to LAYOUT_60_ansi_tsangan_split_rshift (qmk#20864)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_60_ansi_tsangan_split_rshift

    * readme.md: update maintainer username

commit 6ef5135
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 12:03:29 2023 -0700

    Wilba Tech WT60-G2 Community Layout Support (qmk#20861)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan

    * add LAYOUT_60_ansi_wkl_split_bs_rshift

    * add LAYOUT_60_ansi_wkl

    * add LAYOUT_60_hhkb

    * enable Community Layout support

commit b467c1d
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 11:13:40 2023 -0700

    Wilba Tech WT60-G Community Layout Support (qmk#20860)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_60_iso_split_bs_rshift

    * add LAYOUT_60_iso

    * add LAYOUT_60_iso_tsangan_split_bs_rshift

    * add LAYOUT_60_iso_tsangan

    * add LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_ansi

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan

    * add LAYOUT_60_hhkb

    * enable Community Layout support

commit e2ad6ac
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 10:53:18 2023 -0700

    Wilba Tech WT60-D Layout Addition and Touch-Up (qmk#20859)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_60_iso_tsangan_split_bs_rshift

    * update readme.md

    - update maintainer/hardware section to a list
    - update listed maintainer (Wilba6582 -> Wilba)

commit 8c5f075
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 10:37:32 2023 -0700

    Wilba Tech WT60-C Community Layout Support (qmk#20858)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan_split_rshift

    * add LAYOUT_60_hhkb

    * enable Community Layout support

    * readme.md: update maintainer

    Wilba6582 -> Wilba

commit 68c9862
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 10:26:24 2023 -0700

    Wilba Tech WT60-BX Layout Additions and Touch-Up (qmk#20855)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan_split_rshift

    * add LAYOUT_60_hhkb

    * enable Community Layout support

    * readme.md: update maintainer

    Wilba6582 -> Wilba

commit 663ffbc
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 09:59:20 2023 -0700

    Wilba Tech WT60-B Community Layout Support (qmk#20854)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_hhkb

    * enable Community Layout support

commit 43b58b2
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 09:32:54 2023 -0700

    Rama Works U80-A Community Layout Support (qmk#20853)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_tkl_ansi_tsangan

    * enable Community Layout support

commit 1448744
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 01:34:28 2023 -0700

    Rama Works M65-BX Community Layout Support (qmk#20851)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_blocker_tsangan_split_bs

    * add LAYOUT_65_ansi_blocker_tsangan

    * enable Community Layout support

commit 8bc9c1e
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 01:11:35 2023 -0700

    Rama Works M65-B Community Layout Support (qmk#20850)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_blocker_tsangan_split_bs

    * enable Community Layout support

commit 4d9a87c
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 00:43:52 2023 -0700

    Rama Works Koyu Community Layout Support (qmk#20848)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_blocker_tsangan_split_bs

    * enable Community Layout support

commit b7f9f73
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Thu May 11 00:03:49 2023 -0700

    Prophet Layout Additions (qmk#20845)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_60_iso_tsangan_split_bs_rshift

    * add LAYOUT_60_iso_tsangan

    * add LAYOUT_60_iso_wkl_split_bs_rshift

    * add LAYOUT_60_iso_wkl

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan

    * add LAYOUT_60_ansi_wkl_split_bs_rshift

    * add LAYOUT_60_ansi_wkl

    * enable Community Layout support

    * info.json: remove extra line breaks

commit b684353
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed May 10 23:39:10 2023 -0700

    Cypher rev5 Layout Additions (qmk#20844)

    * add matrix_diagram.md

    * info.json: apply friendly formatting, phase 1

    - use four-space indent

    * info.json: apply friendly formatting, phase 2

    - add key labels

    * add LAYOUT_ansi_split_space_split_bs

    * add LAYOUT_ansi_split_space

    * add LAYOUT_ansi_6u_space_split_bs

    * add LAYOUT_ansi_6u_space

    * add LAYOUT_ansi_rwkl_split_bs

    * add LAYOUT_ansi_rwkl

    * add LAYOUT_ansi_wkl_split_bs

    * add LAYOUT_ansi_wkl

    * add LAYOUT_iso_split_space_split_bs

    * add LAYOUT_iso_split_space

    * add LAYOUT_iso_6u_space_split_bs

    * add LAYOUT_iso_6u_space

    * add LAYOUT_iso_rwkl_split_bs

    * add LAYOUT_iso_rwkl

    * add LAYOUT_iso_wkl_split_bs

    * add LAYOUT_iso_wkl

commit 01a77ec
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed May 10 23:18:45 2023 -0700

    Weirdo Geminate60 Layout Additions (qmk#20843)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_60_iso_split_bs_rshift

    * add LAYOUT_60_iso

    * add LAYOUT_60_iso_tsangan_split_bs_rshift

    * add LAYOUT_60_iso_tsangan

    * add LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_ansi

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan

    * enable Community Layout support

commit aec8825
Author: Drashna Jaelre <drashna@live.com>
Date:   Wed May 10 16:06:12 2023 -0700

    [Bug] Fix compilation error introduced by qmk#20669 (qmk#20849)

commit 81f66c1
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed May 10 15:42:59 2023 -0700

    W1-AT Layout Additions (qmk#20842)

    * info.json: apply friendly formatting

    * add matrix_diagram.md

    * add LAYOUT_ansi_wkl_split_bs_rshift

    * add LAYOUT_ansi_wkl

    * add LAYOUT_iso_wkl_split_bs_rshift

    * add LAYOUT_iso_wkl

commit 4ae45ca
Author: Joel Challis <git@zvecr.com>
Date:   Wed May 10 22:55:49 2023 +0100

    Tidy up encoder_map directions (qmk#20847)

commit 853c8d4
Author: QMK Bot <hello@qmk.fm>
Date:   Wed May 10 17:36:15 2023 -0400

    Format code according to conventions (qmk#20846)

commit 2ddad24
Author: Drashna Jaelre <drashna@live.com>
Date:   Wed May 10 14:04:53 2023 -0700

    OLED Driver improvements (qmk#20331)

    Co-authored-by: Sergey Vlasov <sigprof@gmail.com>

commit 8a332e6
Author: Pete Sevander <pete.sevander@gmail.com>
Date:   Wed May 10 18:59:52 2023 +0300

    Fix Mod-Tap combo regression (qmk#20669)

    * Add keyevent for combo keyrecord

    * Fix formatting

    * Update quantum/process_keycode/process_combo.c

    Co-authored-by: Sergey Vlasov <sigprof@gmail.com>

    * Add combo unit-tests and hot-fix process_record_tap_hint

    ...as this function tries to lookup the combo keys passed in. This will
    be refactored in a later pr.

    ---------

    Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
    Co-authored-by: Stefan Kerkmann <karlk90@pm.me>

commit 6f2a1e4
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed May 10 02:03:30 2023 -0700

    Viktus SP_Mini Layout Additions (qmk#20835)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_4l2r_split_bs

    * add LAYOUT_4l2r

    * add LAYOUT_4l_split_bs

    * add LAYOUT_4l

    * add LAYOUT_2r_split_bs

    * add LAYOUT_2r

commit dd50138
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed May 10 01:33:26 2023 -0700

    Viktus SP111 Layout Additions (qmk#20834)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_ansi_split_bs_rshift

    * add LAYOUT_ansi

    * add LAYOUT_iso_split_bs_rshift

    * add LAYOUT_iso

commit 1385fdc
Author: Drashna Jaelre <drashna@drashna.net>
Date:   Wed May 10 00:58:36 2023 -0700

    [Keyboard] Reduce compiled size for prototypist oceanographer's via keymap (qmk#20816)

commit 10a4b6c
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Wed May 10 00:29:40 2023 -0700

    Viktus Smolka Layout Additions (qmk#20833)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * info.json: fix layout overlap

    * add LAYOUT_331_split_bs

    * add LAYOUT_331

    * add LAYOUT_ls11_split_bs

    * add LAYOUT_ls11

    * add LAYOUT_7u_space_split_bs

    * add LAYOUT_7u_space

    * add LAYOUT_313_split_bs

    * add LAYOUT_313

    * add LAYOUT_6u_space_split_bs

    * add LAYOUT_6u_space

    * info.json: clean up line breaks

commit 06fa161
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 23:59:21 2023 -0700

    Viendi 8L Layout Additions (qmk#20832)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_ansi_split_bs_rshift

    * add LAYOUT_ansi

    * add LAYOUT_ansi_arrow_split_bs

    * add LAYOUT_ansi_arrow

    * add LAYOUT_iso_split_bs_rshift

    * add LAYOUT_iso

    * add LAYOUT_iso_arrow_split_bs

    * add LAYOUT_iso_arrow

    * info.json: clean up line breaks

commit c36c6e7
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 23:36:51 2023 -0700

    TKC TKL A/B87 Layout Additions (qmk#20831)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * info.json: correct key positioning

    * add LAYOUT_tkl_ansi_split_bs_rshift

    * add LAYOUT_tkl_ansi

    * add LAYOUT_tkl_iso_split_bs_rshift

    * add LAYOUT_tkl_iso

    * enable Community Layout support

commit 678c1d9
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 23:14:08 2023 -0700

    TKC M0lly Layout Additions (qmk#20830)

    * add matrix_diagram.md

    * refactor keymaps

    - update grid alignment

    * info.json: apply friendly formatting

    * add LAYOUT_ansi_split_bs_rshift

    * add LAYOUT_ansi

    * add LAYOUT_ansi_tsangan_split_bs_rshift

    * add LAYOUT_ansi_tsangan

    * add LAYOUT_iso_split_bs_rshift

    * add LAYOUT_iso

    * add LAYOUT_iso_tsangan_split_bs_rshift

    * add LAYOUT_iso_tsangan

    * info.json: remove extra line breaks

commit 9211425
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 22:52:03 2023 -0700

    TKC California Layout Addition and Touch-Up (qmk#20829)

    * info.json: apply friendly formatting

    * info.json: correct layout data

    Update layout data to my best guess of the actual layout. Seems this product never went into production.

    * rename LAYOUT_all to LAYOUT_ansi_split_bs_rshift

    * add LAYOUT_ansi

    * add matrix_diagram.md

    * Apply suggestions from code review

commit 02a5e1a
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 22:30:49 2023 -0700

    Switchplate Peripherals 910 Layout Additions (qmk#20827)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_65_ansi_blocker_split_bs

    * add LAYOUT_65_ansi_blocker

    * add LAYOUT_65_ansi_blocker_tsangan_split_bs

    * add LAYOUT_65_ansi_blocker_tsangan

    * enable Community Layout support

    * Apply suggestions from code review

commit 3c614d2
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 22:02:33 2023 -0700

    Studio Kestra Nue Layout Additions (qmk#20825)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_iso_split_bs_rshift

    * add LAYOUT_60_ansi

    * add LAYOUT_60_iso

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_ansi_tsangan

    * add LAYOUT_60_iso_tsangan_split_bs_rshift

    * add LAYOUT_60_iso_tsangan

    * add LAYOUT_60_ansi_wkl_split_bs_rshift

    * add LAYOUT_60_ansi_wkl

    * add LAYOUT_60_iso_wkl_split_bs_rshift

    * add LAYOUT_60_iso_wkl

    * enable Community Layout support

    * Apply suggestions from code review

commit 7023940
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 21:30:35 2023 -0700

    Stello65 Beta Layout Additions and Clean-Up (qmk#20824)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * remove encoder hack

    Converts the rotary encoder hack to Encoder Map with QMK Configurator fallback.

    * add LAYOUT_65_ansi_blocker_split_bs

    * add LAYOUT_65_ansi_blocker

    * add LAYOUT_65_ansi_blocker_tsangan_split_bs

    * add LAYOUT_65_ansi_blocker_tsangan

    * add LAYOUT_65_iso_blocker

    * add LAYOUT_65_iso_blocker_split_bs

    * add LAYOUT_65_iso_blocker_tsangan_split_bs

    * add LAYOUT_65_iso_blocker_tsangan

    * enable Community Layout support

    * Apply suggestions from code review

commit e3fbc4f
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 21:01:26 2023 -0700

    SmithRune Iron180 Layout Additions (qmk#20822)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_tkl_f13_ansi_split_bs_rshift

    * add LAYOUT_tkl_f13_ansi

    * add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift

    * add LAYOUT_tkl_f13_ansi_tsangan

    * add LAYOUT_tkl_f13_ansi_wkl_split_bs_rshift

    * add LAYOUT_tkl_f13_ansi_wkl

    * add LAYOUT_tkl_f13_iso_split_bs_rshift

    * add LAYOUT_tkl_f13_iso

    * add LAYOUT_tkl_f13_iso_tsangan_split_bs_rshift

    * add LAYOUT_tkl_f13_iso_tsangan

    * add LAYOUT_tkl_f13_iso_wkl_split_bs_rshift

    * add LAYOUT_tkl_f13_iso_wkl

    * enable Community Layout support

    * info.json: remove extra line breaks

commit de482b5
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 20:28:25 2023 -0700

    senselessclay had60 Layout Additions (qmk#20820)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_60_ansi_split_bs_rshift

    * add LAYOUT_60_iso_split_bs_rshift

    * add LAYOUT_60_ansi

    * add LAYOUT_60_iso

    * add LAYOUT_60_tsangan_hhkb

    * add LAYOUT_60_iso_tsangan_split_bs_rshift

    * add LAYOUT_60_ansi_tsangan

    * add LAYOUT_60_iso_tsangan

    * add LAYOUT_60_ansi_wkl_split_bs_rshift

    * add LAYOUT_60_iso_wkl_split_bs_rshift

    * add LAYOUT_60_ansi_wkl

    * add LAYOUT_60_iso_wkl

    * enable Community Layout support

    * info.json: remove extra line breaks

commit 75b305a
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 20:02:05 2023 -0700

    VCL x SawnsProjects VCL65 Layout Additions (qmk#20819)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_65_ansi_split_bs

    * add LAYOUT_65_ansi

    * add LAYOUT_65_ansi_lwkl_split_bs

    * add LAYOUT_65_ansi_lwkl

    * add LAYOUT_65_ansi_rwkl_split_bs

    * add LAYOUT_65_ansi_rwkl

    * add LAYOUT_65_ansi_wkl_split_bs

    * add LAYOUT_65_ansi_wkl

    * add LAYOUT_65_iso

    * add LAYOUT_65_iso_split_bs

    * add LAYOUT_65_iso_lwkl

    * add LAYOUT_65_iso_lwkl_split_bs

    * add LAYOUT_65_iso_rwkl

    * add LAYOUT_65_iso_rwkl_split_bs

    * add LAYOUT_65_iso_wkl

    * add LAYOUT_65_iso_wkl_split_bs

    * enable Community Layout support

    * info.json: remove extra line breaks

commit 6892ba9
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 19:05:27 2023 -0700

    Sauce Mild Layout Additions (qmk#20818)

    * add matrix_diagram.md

    * info.json: apply friendly formatting, phase 1

    - apply four-space indent

    * info.json: apply friendly formatting, phase 2

    - add key labels

    * add LAYOUT_tkl_ansi_wkl_split_bs_rshift

    * add LAYOUT_tkl_ansi_wkl

    * add LAYOUT_tkl_iso_wkl_split_bs_rshift

    * add LAYOUT_tkl_iso_wkl

    * add position [3, 12] to LAYOUT_all

    Adds the previously-missing `KC_NUHS` key position to the `LAYOUT_all` macro.

    * info.json: edit listed maintainer

    Reference the maintainer's GitHub username.

commit 8819793
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 17:33:25 2023 -0700

    Space Holdings Nebula12B (qmk#20821)

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ortho_4x3

commit 075c087
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 14:47:21 2023 -0700

    saevus cor Layout Additions (qmk#20810)

    * add matrix_diagram.md

    * rename LAYOUT_all to LAYOUT_ansi_blocker_split_bs

    * info.json: apply friendly formatting

    * add LAYOUT_ansi_blocker

    * add LAYOUT_ansi_blocker_tsangan_split_bs

    * add LAYOUT_ansi_blocker_tsangan

commit d4ec165
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 12:33:24 2023 -0700

    RART75 Hotswap Layout Additions (qmk#20789)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * rename LAYOUT_all to LAYOUT_ansi

    * add LAYOUT_ansi_split_bs

    * refactor keymaps to use LAYOUT_ansi_split_bs macro

    * add LAYOUT_ansi_rwkl_split_bs

    * add LAYOUT_ansi_rwkl

commit 638a901
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 10:21:58 2023 -0700

    Rartand Layout Additions (qmk#20799)

    * add matrix_diagram.md

    * info.json: apply friendly formatting

    * add LAYOUT_ansi_arrow

    * add LAYOUT_ansi

    * add LAYOUT_ansi_tsangan_split_rshift

    * add LAYOUT_ansi_split_space

commit 8f6d64e
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 09:07:44 2023 -0700

    RGBKB Pan Layout Additions (qmk#20809)

commit acae650
Author: James Young <18669334+noroadsleft@users.noreply.github.com>
Date:   Tue May 9 03:30:41 2023 -0700

    Ratio65 Solder Layout Additions (qmk#20802)
@sigprof
Copy link
Contributor

sigprof commented May 16, 2023

Placing the call to pre_process_record_kb() after process_combo() results in some annoying behavior:

  • Events that might be a part of some combo won't be passed to pre_process_record_kb(), because process_combo() will return false after storing those events in the combo key buffer. Even if those events are subsequently determined to be not a part of a combo, the combo code will reinject them into action_tapping_process() (or process_record() in the NO_ACTION_TAPPING case), bypassing pre_process_record_kb() for them.
  • Events generated by combos also won't be passed to pre_process_record_kb(), so you can't really consider pre_process_record_kb() to be placed after the combo processing.

Maybe the calls to pre_process_record_kb() and process_combo() should be swapped, so that pre_process_record_kb() receives all events before process_combo()?

@filterpaper
Copy link
Contributor Author

Maybe the calls to pre_process_record_kb() and process_combo() should be swapped, so that pre_process_record_kb() receives all events before process_combo()?

I agree with your suggestion — "pre process" should technically come before processing of combos as well.

@sigprof sigprof mentioned this pull request May 16, 2023
Merged
14 tasks
@filterpaper filterpaper mentioned this pull request May 20, 2023
Merged
14 tasks
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@filterpaper @coquizen
Add a user callback for pre process record (qmk#20584)
e05a105
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@filterpaper @autoferrit
Add a user callback for pre process record (qmk#20584)
504a3f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnusenpai gnusenpai gnusenpai left review comments

@waffle87 waffle87 waffle87 approved these changes

@precondition precondition precondition approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@filterpaper @sigprof @drashna @gnusenpai @precondition @waffle87